Custom Capabilities in Candore #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
force-pushed
the
custom_variations
branch
2 times, most recently
from
bd93fcd to
ab1712a
Compare
JacobCallahan
requested changes
Jun 20, 2024
candore/modules/ssh.py
Outdated
| from urllib.parse import urlparse | ||
|
|
||
|
|
||
| class SSHClient: |
There was a problem hiding this comment.
I think this class can be removed since it performs the same auth checks and validations the Connection class will already do.
https://github.com/JacobCallahan/Hussh/blob/master/src/connection.rs#L259-L282
So you can pass along values (or None) for everything and it will figure it out.
Also, Hussh supports agent-based auth so technically a user with that setup doesn't have to provide a key or password to establish a connection.
Try just having the Session class create the Connection directly.
There was a problem hiding this comment.
Yes, removed the SSHClient class now as it's not needed. Keeping the SSH key option though to pass it down if needed.
jyejare
force-pushed
the
custom_variations
branch
from
ab1712a to
6133eb6
Compare
jyejare
force-pushed
the
custom_variations
branch
from
6133eb6 to
cb25b83
Compare
JacobCallahan
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability for custom validations like RPMs in this PR.