[RHEL10,9,8] Cover restrict repos by host OS, RHEL major versions

[damoore044]

Problem Statement

Cover [SAT-30636], which adds rhel-10 option to the Repository OS Restrict flag.

• 3 repos restricted to RHEL-10/9/8 , using one matching registered host of one the selected rhel versions.
• in 6.16.z and 6.15.z, implicitly selected RHEL versions will be 9/8/7 from supportability.yaml (N-2).

Solution

Implement stubbed coverage, that could have discovered this missing option during initial automation runs.

PRT Case

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos

[damoore044]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos

[Satellite-QE]

PRT Result

Build Number: 9964
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos --external-logging
Test Result : ================= 3 passed, 133 warnings in 1033.52s (0:17:13) =================

[ianballou]

Just one question, but generally ACK from an SME point of view.

[damoore044]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos

[Satellite-QE]

PRT Result

Build Number: 9974
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos --external-logging
Test Result : ================= 3 passed, 131 warnings in 942.14s (0:15:42) ==================

[damoore044]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos

[Satellite-QE]

PRT Result

Build Number: 10111
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos --external-logging
Test Result : ============= 2 passed, 81 warnings, 1 error in 798.64s (0:13:18) ==============

^ one Broker checkout error [RHEL9 chost] for

failed on setup with "podman.errors.exceptions.APIError: 409 Client Error: 
Conflict (cannot exec in a container that is not running; container {} is stopped).

[Satellite-QE]

PRT Result

Build Number: 10112
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos --external-logging
Test Result : ============= 2 passed, 97 warnings, 1 error in 868.83s (0:14:28) ==============

[damoore044]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos

[Satellite-QE]

PRT Result

Build Number: 10115
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos --external-logging
Test Result : ============= 2 passed, 85 warnings, 1 error in 854.92s (0:14:14) ==============

[vsedmik]

Left a couple of proposals to consider and a question.

[vsedmik]

Suggested change

	:id: fd40842f-48c3-4505-a670-235d8a5f466b
	:id: fd40842f-48c3-4505-a670-235d8a5f466b
	:parametrized: yes

[vsedmik]

Suggested change

	for repo in custom_repos:
	assert repo.label in sub_man_repos
	assert all(repo.label in sub_man_repos for repo in custom_repos)

[vsedmik]

Aren't the rhel_versions major already?

>>> rhel_versions = [
                    rhel_major_ver
                    for rhel_major_ver in settings.supportability.content_hosts.rhel.versions
                    if 'fips' not in str(rhel_major_ver)
                ][-3:]
>>> rhel_versions
[8, 9, 10]

Suggested change

rhel_majors = [ver for ver in rhel_versions]

[damoore044]

yes they are I just made a copy list (rhel_majors) to edit without editing the original list (rhel_versions).

[vsedmik]

Suggested change

	result = target_sat.execute(
	f'hammer repository update --os-versions "{formatted}"'
	f' --id {r.id} --organization-id {org.id}'
	)
	assert result.status == 0, f'{result.stdout}'
	target_sat.cli.Repository.update({'os-version': formatted, 'id': r.id})

should throw exception for non-zero result

[vsedmik]

Suggested change

	for label in disabled_repos_labels:
	assert label not in sub_man_repos
	assert all(label not in sub_man_repos for label in disabled_repos_labels)

[damoore044]

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos[rhel9-ipv4]

[Satellite-QE]

PRT Result

Build Number: 10126
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_subscription.py::test_positive_os_restriction_on_repos[rhel9-ipv4] --external-logging
Test Result : =================== 9 warnings, 1 error in 599.97s (0:09:59) ===================