Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build.sh executable via post-action #2

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Make build.sh executable via post-action #2

merged 1 commit into from
Feb 9, 2018

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Feb 9, 2018

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 0007c69 into SaturnFramework:master Feb 9, 2018
@Krzysztof-Cieslak
Copy link
Member

❤️

@rmunn rmunn deleted the executable-build-script branch February 9, 2018 13:27
@theimowski theimowski mentioned this pull request Feb 9, 2018
Closed
@rmunn
Copy link
Contributor Author

rmunn commented Feb 23, 2018

Apparently the condition should have been "(OS != \"Windows_NT\")" (see SAFE-Stack/SAFE-template#36). I'll open a new PR to fix this mistake.

@rmunn
Copy link
Contributor Author

rmunn commented Feb 23, 2018

PR #3 should fix that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needed to explicitly chmod u+x on build.sh
2 participants
@rmunn @Krzysztof-Cieslak