-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/websockets #82
Feat/websockets #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I found the implementation ws router implementation SUPER COOOL! 🙌🏼
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 88.39% 88.96% +0.57%
==========================================
Files 63 66 +3
Lines 1904 2103 +199
Branches 196 212 +16
==========================================
+ Hits 1683 1871 +188
- Misses 218 229 +11
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🚀
I found one minor, but we can fix it in the upcoming PRs 👍
@@ -27,7 +28,7 @@ export class FilterExecutor { | |||
exceptionFilter: ExceptionFilter, | |||
context: HttpContext, | |||
error: unknown, | |||
): Response | undefined { | |||
): Response | undefined | { topic: string; data: unknown } { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor, we can fix it later
): Response | undefined | { topic: string; data: unknown } { | |
): Response | undefined | WebSocketPayload { |
Description
Websocket are a must for real-time application such as chats or video-games.
This PR introduces a new router and associated decorators, the WebsocketRouter.
It has the same features as the OG HttpRouter :
Example:
Issue Ticket Number
Fixes #(issue_number)
Type of change
not work as expected)
Checklist:
deno lint
ANDdeno fmt
ANDdeno task test
and got noerrors.
in CONTRIBUTING.md
Pull Requests for the same
update/change?