Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #12

Merged
merged 23 commits into from
Nov 3, 2021
Merged

Update workflows #12

merged 23 commits into from
Nov 3, 2021

Conversation

renatoabreu11
Copy link
Contributor

No description provided.

testdata/main.kt Show resolved Hide resolved
testdata/main.kt Show resolved Hide resolved
testdata/main.kt Show resolved Hide resolved
testdata/main.kt Show resolved Hide resolved
@renatoabreu11 renatoabreu11 marked this pull request as ready for review September 1, 2020 18:21
@renatoabreu11 renatoabreu11 requested a review from fbenz September 1, 2020 18:21
Copy link

@fbenz fbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

@@ -0,0 +1,6 @@
import java.math.BigDecimal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] reported by reviewdog 🐶
class Test should be declared in a file named Test.kt (cannot be auto-corrected)

@@ -0,0 +1,6 @@
import java.math.BigDecimal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] reported by reviewdog 🐶
File must end with a newline (\n)

@@ -0,0 +1,6 @@
import java.math.BigDecimal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] reported by reviewdog 🐶
Unused import

@@ -0,0 +1,6 @@
import java.math.BigDecimal
import java.util.*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] reported by reviewdog 🐶
Wildcard import (cannot be auto-corrected)

@renatoabreu11 renatoabreu11 merged commit a6c5311 into master Nov 3, 2021
@renatoabreu11 renatoabreu11 deleted the custom-version branch November 3, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants