Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added emojies, lines diff checker, app name #19

Merged
merged 15 commits into from
Feb 9, 2021
Merged

Added emojies, lines diff checker, app name #19

merged 15 commits into from
Feb 9, 2021
+131 −48

Conversation

marinakalyuzhnaya
Copy link

@marinakalyuzhnaya marinakalyuzhnaya commented Dec 18, 2020 •
edited
Loading

Problem solved:

  1. added emojies to highlight comment with red/green colour for diff
  2. added possibility to show details only for changed lines , please note, that this will work only if you have base lcov file, if not previous code will work without changes
  3. added possibility to add app-name (needed mostly for singe repo with diff siblings)

@marinakalyuzhnaya
added colors

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a9b887b
@marinakalyuzhnaya
Merge branch 'master' of github.com:ScaCap/monorepo-jest-reporter-act…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
37f7bf7 
…ion into add-colors
@marinakalyuzhnaya
build

Verified

This commit was signed with the committer’s verified signature. The key has expired.
doubledup David Dunn
GPG key ID: 99F10972153A72B0
Expired
Verified
Learn about vigilant mode
d6d387f
@github-actions
Copy link

github-actions bot commented Dec 18, 2020 •
edited
Loading

Coverage after merging add-colors into master

100.00%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   html.js100%100%100%
   lcov.js100%100%100%
   tabulate.js100%100%100%

@marinakalyuzhnaya marinakalyuzhnaya force-pushed the add-colors branch 2 times, most recently from dba0401 to 5ba1c0c Compare December 18, 2020 10:07
Weetbix
Weetbix approved these changes Dec 18, 2020
View reviewed changes
Copy link

@Weetbix Weetbix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, saw it in action with your other PR

eeshdarthvader
eeshdarthvader approved these changes Dec 18, 2020
View reviewed changes
Copy link

@eeshdarthvader eeshdarthvader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@marinakalyuzhnaya marinakalyuzhnaya changed the title Added emojies to the comment diff part Added emojies, lines diff checker Feb 5, 2021
@marinakalyuzhnaya marinakalyuzhnaya changed the title Added emojies, lines diff checker Added emojies, lines diff checker, app name Feb 5, 2021
janory
janory approved these changes Feb 5, 2021
View reviewed changes
Copy link

@janory janory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Weetbix
Weetbix approved these changes Feb 9, 2021
View reviewed changes
Copy link

@Weetbix Weetbix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great again, I've seen it in action :)

eeshdarthvader
eeshdarthvader requested changes Feb 9, 2021
View reviewed changes
Copy link

@eeshdarthvader eeshdarthvader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few changes added.

eeshdarthvader
eeshdarthvader reviewed Feb 9, 2021
View reviewed changes
@marinakalyuzhnaya
Copy link
Author

Looks great again, I've seen it in action :)

I already have some improvements ideas, how to show only changed lines without having a base file. :)

eeshdarthvader
eeshdarthvader approved these changes Feb 9, 2021
View reviewed changes
Copy link

@eeshdarthvader eeshdarthvader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. ❤️

@eeshdarthvader eeshdarthvader merged commit 8edff1e into master Feb 9, 2021
@eeshdarthvader eeshdarthvader deleted the add-colors branch February 9, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weetbix Weetbix

@eeshdarthvader eeshdarthvader

@janory janory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marinakalyuzhnaya @Weetbix @eeshdarthvader @janory