Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default shadow offset does conform to material design guidelines #20

Closed
danhawkes opened this issue Mar 31, 2015 · 3 comments
Closed

Default shadow offset does conform to material design guidelines #20

danhawkes opened this issue Mar 31, 2015 · 3 comments

Comments

@danhawkes
Copy link

The light source in material design is always directly above the element, so shadows do not ordinarily have an x offset.

http://www.google.com/design/spec/what-is-material/environment.html#environment-3d-world
http://www.google.com/design/spec/components/buttons.html#buttons-floating-action-button

Would you please consider changing the default x offset to zero, as the typical user likely just wants a button with the recommended style?

@vbaidak
Copy link
Member

vbaidak commented Mar 31, 2015

Hi danhawkes,

You're completely right

Yes, these values will be fixed and the shadow defaults will be the same as described in Material Design Guidelines

Also a responsive elevation will be added by default with the option to toggle it as user TurKurT656 suggested

All this stuff is currently under development, however it is almost completed and soon will be release (I think this weekend or the next one)

So, check for updates && have a nice day

@danhawkes
Copy link
Author

Great, and thank you for your work on this library.

vbaidak pushed a commit that referenced this issue May 12, 2015
…stion - Pressed State #11 #  Default shadow offset does conform to material design guidelines #20 #  PayPal donate link returns error #21
@vbaidak
Copy link
Member

vbaidak commented May 12, 2015

Fixed in version 1.1.0

@vbaidak vbaidak closed this as completed May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants