Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding official py3.7 support #622

Closed
m1keil opened this issue Feb 4, 2019 · 3 comments
Closed

Adding official py3.7 support #622

m1keil opened this issue Feb 4, 2019 · 3 comments
Labels
priority: low priority
Milestone
2.1.1

Comments

@m1keil
Copy link
Contributor

m1keil commented Feb 4, 2019 •
edited
Loading

3.7 was released more than 6 months ago. 3.8 is scheduled to be released in October. Personally, I've been using Sceptre v2 with 3.7 for few months now without any issues. Is it time to add py37 to tox?
@ngfgrant
Copy link
Contributor

ngfgrant commented Feb 5, 2019

Hey @m1keil if you could try add 3.7 to tox and run tests, if everything passes then I am happy to add official support for 3.7. If there are things that are breaking then for v2 we will support >=2.7-3.6 for now. Plan is to drop Py2 for v3.

devenney pushed a commit to devenney/sceptre that referenced this issue Feb 9, 2019
📌 Resolve Sceptre#622: Add official Python 3.7 support
8c7d9e8 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
@devenney
Copy link
Contributor

devenney commented Feb 9, 2019

I tinkered with this a bit when I was getting set up. For what it's worth, the only issues I experienced were with the test dependencies:

  • freezegun has to be upgraded to 0.3.11.
  • moto has to be upgraded to 1.3.7.

There is an outstanding deprecation warning coming from PyYAML which is covered by PyYAML #202. This either pollutes Sceptre output or requires silencing the deprecation warning in sceptre/__init__.py like so:

import warnings

with warnings.catch_warnings():
    warnings.filterwarnings("ignore", category=DeprecationWarning)

Suppose it comes down to whether you want to silence deprecation warnings in the project @ngfgrant, but Python 3.7 support seems functional. I've pushed the code I have (see above) for example.

@ngfgrant
Copy link
Contributor

@devenney thanks - going to update this anyway. Also going to evaluate moving from PyYaml in favour of ruamel as it is better maintained and PyYaml.

devenney pushed a commit to devenney/sceptre that referenced this issue Feb 26, 2019
[Resolve Sceptre#622] 📌 Add official Python 3.7 support
8ded21d 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
@devenney devenney mentioned this issue Feb 26, 2019
Merged
9 tasks
ngfgrant pushed a commit that referenced this issue Feb 26, 2019
@ngfgrant
[Resolve #622] 📌 Add official Python 3.7 support
4e284aa 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
ngfgrant pushed a commit that referenced this issue Feb 26, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
b2acd91 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
ngfgrant pushed a commit that referenced this issue Feb 28, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
6c53c18 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
ngfgrant pushed a commit that referenced this issue Mar 1, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
33e1da6 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
@ngfgrant ngfgrant added this to the 2.1.1 milestone Mar 4, 2019
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
bd3475c 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Signed-off-by: Brendan Devenney <[email protected]>
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
18a847c 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
26804ea 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
d140c51 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
abd332d 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
ngfgrant pushed a commit that referenced this issue Jun 13, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
86f1bfe 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
ngfgrant pushed a commit that referenced this issue Jun 26, 2019
@ngfgrant
[Resolve #622] Add official Python 3.7 support
d4db470 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
thawkson pushed a commit to thawkson/sceptre that referenced this issue Feb 6, 2021
@thawkson
[Resolve Sceptre#622] Add official Python 3.7 support
eae7299 
Note that this commit suppressed DeprecationWarnings due to dependencies
which have not yet updated their use of collections.abc.

Add pyenv to CI: support multiple Python versions

* Bump CI Docker image version (to 0.4)
* Add pyenv to Docker image
* Support py27, py36, py37

Fix CI interaction with moto 1.3.7. Works around getmoto/moto#1924 by
ensuring garbage defaults are set in the environment.

Update setup.py for Python3.7 support

Add package requirements for testing on python3.7/win
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low priority
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
3 participants
@m1keil @ngfgrant @devenney