Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sceptre version 2.1.1 breaks backward compatibility with paths ending in trailing slash #740

Closed
jfarr opened this issue Jun 13, 2019 · 3 comments

Comments

@jfarr
Copy link

jfarr commented Jun 13, 2019

I started getting the following error after upgrading to version 2.1.1:

'dev/' is an invalid path string. Paths should not have trailing slashes.

This worked fine in 2.1.0. Removing the trailing slash is not a workaround due to the way sceptre resolves paths by prefix matching. If I have a stack group named dev and a stack group named dev-private then running sceptre launch dev will launch both stack groups. The trailing slash in sceptre launch dev/ is necessary to disambiguate. (See #546) This completely breaks all of our sceptre-based deployment automation.

@ngfgrant
Copy link
Contributor

#731 Fixes the issue regarding exact stack names. Allowing the forward slash was a bug. Fix above due out soon.

@jfarr
Copy link
Author

jfarr commented Jun 13, 2019

Thanks for the quick response @ngfgrant, I'll wait for that fix to come out then. I wasn't sure what the right fix was so I figured I'd log an issue before attempting a PR myself, glad it's already being taken care of. Really great tool so far BTW, please keep up the good work!

@jfarr jfarr closed this as completed Jun 13, 2019
@ngfgrant
Copy link
Contributor

Thank you for raising it @jfarr please point out anything else you come across that doesn't look right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants