-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #546] select command stacks based on exact stack-group name #731
Conversation
@cornerman thanks for the PR. LGTM but I'd like someone with windows to test this if they could basically I am intrigued as to whether the use of |
We might want to add a check for yaml files. If you have a config file Edit: But it could again be ambiguous, if you have a folder |
abd332d
to
86f1bfe
Compare
Would love to see this make it into the next release. This issue has tripped up colleagues on my team, luckily in non-prod environments 😄. |
Guys its my bad for letting this stay open as long as it has. Definitely need to get this merged and I am happy with this PR as it is. As per my original comment there may be some windows issues with sep but I am pretty sure there won't be. @cornerman if you have time could you rebase this off master and resolve the conflict in |
I took the liberty of rebasing this. Please check rseuchter@f5a5181 An hour or two ago, I ran into this bug with a colleague. While we found a workaround it caused some serious concern. After realizing this has been lying around for so long I thought I rather help get this resolved. |
f3f18eb
to
f5a5181
Compare
@rseuchter Thank you! That is great. I just reset my branch to your commit and pushed! @ngfgrant This PR is now rebased |
This PR has been stale. Still, I feel the underlying issue is critical. Any ideas @ngfgrant? |
I’m going to get to this and others this weekend. Unauthorised makes sense (to me). |
When specifying a
command_path
for cli operations, commands will be executed on all stack-groups which share a prefix withcommand_path
. So, if you have two configsenv1
andenv2
, but then provideenv
as yourcommand_path
, bothenv1
andenv2
will be executed.In my opinion,
env
is not a valid stack-group and should therefore not start anything. We should either specifyenv1
orenv2
expicitly or alternatively group them under one common directorymy-envs
when you want to launch stack together.PR Checklist
[Resolve #issue-number]
.make test
) are passing.make lint
) checks.and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit