Invalid characters in context key names cause the lookup promise to never resolve #49
Assignees
Labels
Comments
mofogasy
added a commit
that referenced
this issue
Mar 26, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
danielwiehl
pushed a commit
that referenced
this issue
Apr 12, 2021
…starting with a colon closes #49 BREAKING CHANGE: Allowing context key names containing forward slashes or starting with a colon introduced a breaking change in the host/client communication protocol. The messaging protocol between host and client HAS CHANGED for context value lookup using the `ContextService`. Therefore, you must update the host and affected clients to the new version together. The API has not changed; the breaking change only applies to the `@scion/microfrontend-platform` version. To migrate: - Upgrade host and clients (which use the `ContextService`) to `@scion/[email protected]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Contextual data cannot be associated with a key that contains forward slashes or that starts with a colon.
To Reproduce
Steps to reproduce the behavior:
<sci-router-outlet>using the keya/b/cContextServicebean, as follows:ContextService.lookup('a/b/c')Expected behavior
There should be no restrictions on naming context key names. Alternatively, it would be conceivable that at least an error is thrown when using invalid characters in the key.
Environment
SCION Microfrontend Platform version:
1.0.0-beta.8The text was updated successfully, but these errors were encountered: