Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/124 #180

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Issue/124 #180

merged 1 commit into from
Oct 27, 2022

Conversation

danielwiehl
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, removal of deprecations, etc)
  • Deps (changes related to updating dependencies)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #124

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danielwiehl danielwiehl force-pushed the issue/124 branch 4 times, most recently from 7fce493 to f01cb42 Compare October 25, 2022 13:30
@danielwiehl
perf(platform/messaging): transport intents to subscribed clients only
9b7b535 
Previously, an intent was transported to all qualified clients regardless of whether the client had a subscription for the intent, causing unnecessary traffic on the message bus and is a prerequisite for supporting retained intents.

closes #124
@Marcarrian Marcarrian merged commit 4247e9d into master Oct 27, 2022
@Marcarrian Marcarrian deleted the issue/124 branch October 27, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcarrian Marcarrian Marcarrian approved these changes

@mofogasy mofogasy Awaiting requested review from mofogasy

Assignees

@Marcarrian Marcarrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielwiehl @Marcarrian