Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix pagination #1503

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Attempt to fix pagination #1503

merged 6 commits into from
Jun 13, 2024

Conversation

Ingvord
Copy link
Member

@Ingvord Ingvord commented Jun 13, 2024

Resolves #1502

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@Ingvord
Copy link
Member Author

Ingvord commented Jun 13, 2024

All green 🍾

@Ingvord Ingvord marked this pull request as ready for review June 13, 2024 14:59
@Ingvord Ingvord requested a review from bpedersen2 June 13, 2024 14:59
@Ingvord Ingvord mentioned this pull request Jun 13, 2024
Closed
bpedersen2
bpedersen2 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and pagination works again with the new interface.

@Ingvord Ingvord merged commit 7ca4afd into master Jun 13, 2024
7 checks passed
@Ingvord Ingvord deleted the fix-1502 branch June 13, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpedersen2 bpedersen2 bpedersen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets: Pagination broken with new search interface
2 participants
@Ingvord @bpedersen2