-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AutoTaylorDiff #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also bump the minor version
Just fixed and bumped version |
@gdalle I'm a bit confused, how to fix this documentation error? |
You should include Lines 33 to 37 in d468741
|
Can I run the workflow again? |
See #100 |
Thanks! Since the error is unrelated, could you first merge this before solving the token issue, so that I can deal with SciML/NonlinearSolve.jl#507 ? I believe on the main branch the CI will work just fine. 😄 |
I also think the CI will work, can you just do a vibe check and confirm that your tests should cover all the additional code, for lack of a codecov report? |
Yes, I can confirm that all new code is covered (constructor function is called with both arg and without arg; |
I see, codecov is still not working, so indeed a permission problem |
If you don't have concerns other than the codecov, it's ready to merge? |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Adding type AutoTaylorDiff, currently only have order as type parameter.