-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added an edge case for LatticeReactionSystem #1164
base: master
Are you sure you want to change the base?
test: added an edge case for LatticeReactionSystem #1164
Conversation
Signed-off-by: sivasathyaseeelan <[email protected]>
Just checking, exactly what is this meant to test? That you cannot create |
Signed-off-by: sivasathyaseeelan <[email protected]>
Sounds good. I'd probably call it Also, in the test already run |
Yeah make sense. I will modify the test! |
Signed-off-by: sivasathyaseeelan <[email protected]>
@TorkelE I have modified the test as per your above comments. Could you please review it? |
Looks good, thanks a lot :) |
This needs to have master merged into it to get the doc build error fix. @TorkelE feel free to merge when you are happy. |
(I guess we can ignore the doc failure since this is just updating a test.) |
I have merged master into this, happy to take from here @sivasathyaseeelan (thanks again for the PR :) ) |
I have added an edge cases to test LatticeReactionSystem which were not tested before.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.