-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependency management #936
Conversation
39366d4
to
288e71a
Compare
The remaining failures are from the broken Forward Mode in SciMLSensitivity SciML/SciMLSensitivity.jl#1099. |
Still lets wait for the upstream fixes to land before moving ahead with this |
Well the upstream fixes are in but 😅. Though I will say I did see this come up when playing around. This is why I asked:
When doing ArrayInterface.restructure for the SciMLStructures compatibility, I noticed that TrackedArrays and ComponentArrays didn't mix well. In particular, a TrackedArray on a ComponentArray had the wrappers the wrong way around, and so the indexing didn't work out. And the other way seemed to not make the ComponentArray of TrackedArray structure, but instead TrackedReals. But I know you had to have tried this with Lux before so it must be a recent regression? So what you're seeing there is precisely |
This is not hard to fix, I will do it in ComponentArrays |
Once SciML/ComponentArrays.jl#269 lands, tests should be green again! |
collocate_data
withDataInterpolations
#935)