Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency management #936

Merged
merged 11 commits into from
Sep 10, 2024
Merged

fix: dependency management #936

merged 11 commits into from
Sep 10, 2024

Conversation

avik-pal
Copy link
Member

test/Project.toml Outdated Show resolved Hide resolved
docs/src/examples/mnist_conv_neural_ode.md Outdated Show resolved Hide resolved
docs/src/examples/mnist_conv_neural_ode.md Outdated Show resolved Hide resolved
docs/src/examples/mnist_neural_ode.md Outdated Show resolved Hide resolved
docs/src/examples/mnist_neural_ode.md Outdated Show resolved Hide resolved
docs/src/examples/mnist_neural_ode.md Outdated Show resolved Hide resolved
docs/src/examples/mnist_neural_ode.md Outdated Show resolved Hide resolved
@avik-pal avik-pal changed the title fix: dependency management fix: dependency management [Don't Merge] Aug 27, 2024
@avik-pal avik-pal force-pushed the ap/unused branch 2 times, most recently from 39366d4 to 288e71a Compare August 27, 2024 22:06
@avik-pal avik-pal changed the title fix: dependency management [Don't Merge] fix: dependency management Aug 27, 2024
@avik-pal
Copy link
Member Author

The remaining failures are from the broken Forward Mode in SciMLSensitivity SciML/SciMLSensitivity.jl#1099.

@avik-pal
Copy link
Member Author

Still lets wait for the upstream fixes to land before moving ahead with this

@ChrisRackauckas
Copy link
Member

Well the upstream fixes are in but 😅. Though I will say I did see this come up when playing around. This is why I asked:

Did ComponentArrays of Tracker always store as Array{TrackedReal} or did it create TrackedArray with views of TrackedArray on sub parts?

When doing ArrayInterface.restructure for the SciMLStructures compatibility, I noticed that TrackedArrays and ComponentArrays didn't mix well. In particular, a TrackedArray on a ComponentArray had the wrappers the wrong way around, and so the indexing didn't work out. And the other way seemed to not make the ComponentArray of TrackedArray structure, but instead TrackedReals. But I know you had to have tried this with Lux before so it must be a recent regression? So what you're seeing there is precisely ArrayInterface.restructure(x::ComponentArray, y::SomethingTracked) going awry, and fixing that behavior is the fix. We don't have a test for that exact case in SciMLSensitivity though, would probably be good to add.

@avik-pal
Copy link
Member Author

avik-pal commented Sep 2, 2024

So what you're seeing there is precisely ArrayInterface.restructure(x::ComponentArray, y::SomethingTracked) going awry, and fixing that behavior is the fix.

This is not hard to fix, I will do it in ComponentArrays

@avik-pal
Copy link
Member Author

avik-pal commented Sep 2, 2024

Once SciML/ComponentArrays.jl#269 lands, tests should be green again!

@avik-pal avik-pal merged commit 9679ae5 into master Sep 10, 2024
12 of 14 checks passed
@avik-pal avik-pal deleted the ap/unused branch September 10, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with collocate_data with DataInterpolations
2 participants