Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

mul! implemented for 2d and 3d multiplication with NNlib #128

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

ajozefiak
Copy link
Contributor

@ajozefiak ajozefiak commented Jul 2, 2019

The implementation could be made cleaner, but the general working idea is present in my branch.

@ChrisRackauckas
Copy link
Member

Is there a test which hits this dispatch?

@ajozefiak
Copy link
Contributor Author

ajozefiak commented Jul 2, 2019

@ChrisRackauckas I'll need to add a fewmore tests, but the tests I've created for the fallback in differentiation_dimension.jl hit the 3D case along with the fallback for higher dimensions. I will need to explicitly test the 2D case, but that is also being hit (for differentiation along rows) in a few places in derivative_operator_interface.jl

@ChrisRackauckas ChrisRackauckas merged commit 7213994 into master Jul 2, 2019
@ChrisRackauckas ChrisRackauckas deleted the nnlib_convolutions branch July 2, 2019 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants