This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
allow multiple depvars in MOLFiniteDifference #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the philosophy on adding more tests vs editing the existing ones to capture the more complicated case (2 variables instead of 1)? |
|
Very dependent on the use case. It's good to have some tests that catch a bunch, but also having some nice small tests that are good to copy-paste and play with is also good. |
…ue-374-multiple-depvars
valentinsulzer
changed the title
| @@ -31,7 +33,7 @@ function SciMLBase.symbolic_discretize(pdesys::ModelingToolkit.PDESystem,discret | |||
|
|
|||
| # Build symbolic variables | |||
| indices = CartesianIndices(((axes(s)[1] for s in space)...,)) | |||
| depvars = map(pdesys.depvars) do u | |||
| depvarsdisc = map(depvars) do u | |||
There was a problem hiding this comment.
what does the name mean?
There was a problem hiding this comment.
discretized - I found it confusing that depvars != pdesys.depvars
There was a problem hiding this comment.
good point, yes it was a consequence of writing too fast. Thanks for correcting it.
ChrisRackauckas
approved these changes
Apr 20, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374