Skip to content

Commit

Permalink
Don't use qr! on SparseMatrixCSC
Browse files Browse the repository at this point in the history
It's really slow, see #283
  • Loading branch information
ChrisRackauckas committed Mar 24, 2023
1 parent a5b11d7 commit bd71331
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/factorization.jl
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ end

function do_factorization(alg::QRFactorization, A, b, u)
A = convert(AbstractMatrix, A)
if alg.inplace && (!(A isa SparseMatrixCSC) || VERSION >= v"1.8-")
if alg.inplace && !(A isa SparseMatrixCSC)
fact = qr!(A, alg.pivot)
else
fact = qr(A) # CUDA.jl does not allow other args!
Expand Down

0 comments on commit bd71331

Please sign in to comment.