-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastLAPACK #153
FastLAPACK #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 65.28% 60.77% -4.52%
==========================================
Files 9 9
Lines 579 622 +43
==========================================
Hits 378 378
- Misses 201 244 +43
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I think the high level types is probably easiest.
That would be cool if possible. |
Now for the real test: does it actually end up faster than direct OpenBLAS/MKL? |
Well it just avoids allocations right? That's the only change AFAICT. So it should be fast for resolves |
Run the formatter? |
Actually, I'll run the formatter. I want to update the docs anyways. |
Oh oops. @ChrisRackauckas just formatted and added a simple set of tests. |
oh that's more than fine. |
This is just a basic set of functions I was able/willing to develop on my laptop at sea. I've only tested
A*x \approx b
for those factorizations right now.I'll add tests shortly. A few questions:
set_A
with a different size matrix? Problematically I triggered a segfault once when playing with the sizing of A this evening, so I'll have to track that down. It's supposed to just error (and mostly does). FastLAPACKInterface.jl doesn't provide a method to resize workspaces as far as I can tell.