Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary doc bits after unification #169

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Remove unnecessary doc bits after unification #169

merged 5 commits into from
Aug 15, 2022

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #169 (f4256e5) into main (bb1f9f4) will decrease coverage by 6.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   66.87%   60.40%   -6.48%     
==========================================
  Files           9        9              
  Lines         631      639       +8     
==========================================
- Hits          422      386      -36     
- Misses        209      253      +44     
Impacted Files Coverage Δ
src/LinearSolve.jl 0.00% <0.00%> (-75.00%) ⬇️
src/default.jl 40.56% <0.00%> (-28.83%) ⬇️
src/common.jl 74.00% <0.00%> (-10.00%) ⬇️
src/factorization.jl 80.09% <0.00%> (-1.50%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ArnoStrouwen
Copy link
Member Author

Should the basic installation code example be in all package docs?
Currently it is in some but not others.
I will make it uniform in whichever preferred direction.

Some packages have a home, others have an overview. I prefer overview.

@ChrisRackauckas
Copy link
Member

I think these bits should stay. Every package should have an intro IMO.

for guidance on PRs, issues, and other matters relating to contributing to ModelingToolkit.
- There are a few community forums:
- the #diffeq-bridged channel in the [Julia Slack](https://julialang.org/slack/)
- [JuliaDiffEq](https://gitter.im/JuliaDiffEq/Lobby) on Gitter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the one that I showed? It had the updated Zulip form.

@ChrisRackauckas ChrisRackauckas merged commit 9622091 into SciML:main Aug 15, 2022
Comment on lines -3 to -4
pages = [
"Home" => "index.md",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the sidebar pretty ugly since it will use LinearSolve.jl: High-Performance Unified Linear Solvers (the title on the index.md page) instead of Home. (Compare https://linearsolve.sciml.ai/dev/ with https://linearsolve.sciml.ai/stable/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no way to have the title bar not be ugly while having the <title> element of the page be something snappy for search engine optimization.
JuliaDocs/Documenter.jl#1898
Discussing with Chris, we decided optimizing for SEO and fixing the title bar later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. For now I think having the results show up properly in Google is worth more than a cleaner sidebar. When we can unlink the two then it will get updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants