Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example blocks #185

Merged
merged 2 commits into from
Aug 28, 2022
Merged

example blocks #185

merged 2 commits into from
Aug 28, 2022

Conversation

ArnoStrouwen
Copy link
Member

@ArnoStrouwen ArnoStrouwen commented Aug 27, 2022

Fixes #186

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #185 (b5db038) into main (ec2dfad) will decrease coverage by 3.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   65.24%   61.35%   -3.90%     
==========================================
  Files           9        9              
  Lines         656      621      -35     
==========================================
- Hits          428      381      -47     
- Misses        228      240      +12     
Impacted Files Coverage Δ
src/LinearSolve.jl 0.00% <0.00%> (-75.00%) ⬇️
src/default.jl 39.06% <0.00%> (-25.09%) ⬇️
src/common.jl 78.94% <0.00%> (-5.06%) ⬇️
src/factorization.jl 80.09% <0.00%> (-2.00%) ⬇️
src/iterative_wrappers.jl 69.39% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

@ChrisRackauckas
Copy link
Member

oops, accidentally just did it to master. Rebase.

@ArnoStrouwen
Copy link
Member Author

For strict fix #186 first ?

@ChrisRackauckas
Copy link
Member

yeah, why is ldiv! not on Diagonal? It's throwing away the operator for some reason and just keeping the array. That's weird.

@ChrisRackauckas ChrisRackauckas merged commit 988206d into SciML:main Aug 28, 2022
@ArnoStrouwen ArnoStrouwen deleted the patch-4 branch August 28, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ second example broken
2 participants