Add an assumptions mechanism for type-stable default help, and nonsquare #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Aug 27, 2022
YingboMa
reviewed
Aug 27, 2022
| alg = GenericFactorization() | ||
| function defaultalg(A, b, ::OperatorAssumptions{nothing}) | ||
| issquare = size(A, 1) == size(A, 2) | ||
| defaultalg(A, b, OperatorAssumptions(Val(issquare))) |
There was a problem hiding this comment.
This seems type unstable. Is that intentional, or does Julia always union split here?
There was a problem hiding this comment.
We need to have some point where a type choice is made, because then it sets the algorithm type. Things like the ODE solver would just set the assumptions at the type level.
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 65.24% 63.92% -1.32%
==========================================
Files 9 9
Lines 656 621 -35
==========================================
- Hits 428 397 -31
+ Misses 228 224 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177