CompatHelper: bump compat for KLU to 0.4, (keep existing compat) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ChrisRackauckas
force-pushed
the
compathelper/new_version/2022-09-14-00-14-44-422-00573357958
branch
from
2a8f7bd to
a4309ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 65.86% 68.13% +2.26%
==========================================
Files 9 9
Lines 627 681 +54
==========================================
+ Hits 413 464 +51
- Misses 214 217 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
What's the status on this? |
|
I'm working on both the UMFPACK and KLU changes right now for 1.9. I'll pick this up as well. IIRC 0.4 only had changes I needed for SuiteSparseGraphBLAS.jl, nothing this package needed to pick up |
|
Yes the only change was to use an AbstractKLUFactorization so I can extend things more easily in other packages. |
rayegun
approved these changes
Oct 19, 2022
ChrisRackauckas
deleted the
compathelper/new_version/2022-09-14-00-14-44-422-00573357958
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
KLUpackage from0.3.0to0.3.0, 0.4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.