-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial example: SIS spatial epidemic model #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first pull request, I don't know whether I do it right or not. Sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks!
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 13 13
Lines 940 940
=======================================
Hits 830 830
Misses 110 110 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
docs/src/tutorials/sispde.md
Outdated
|
||
See more solvers in [Steady State Solvers · DifferentialEquations.jl](https://diffeq.sciml.ai/stable/solvers/steady_state_solve/) | ||
|
||
```julia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove the doctesting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Chris, Project.toml only includes OrdinaryDiffEq, document.yml is not successful. I an afraid that I mess you doctest up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, Chris. Thank you.
@xtalax there are test failures on master? That's not good. |
The CI was passing on last merge, the fail was on nonuniform right? There are some rand calls on those tests, some of those values may push the tests outside of tolerance. I can hard code some suitable values if that is preferable. |
@Song921012 please push a dummy commit to verify this |
|
Sorry, wrong click! I will dummy commit. @xtalax |
Tutorial on solving steady state of SIS (suspected-infected-suspected) reaction-diffusion model.