Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial example: SIS spatial epidemic model #118

Merged
merged 5 commits into from
Jun 18, 2022

Conversation

Song921012
Copy link
Contributor

Tutorial on solving steady state of SIS (suspected-infected-suspected) reaction-diffusion model.

Copy link
Contributor Author

@Song921012 Song921012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first pull request, I don't know whether I do it right or not. Sorry

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks!

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #118 (43b185b) into master (4a539bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          13       13           
  Lines         940      940           
=======================================
  Hits          830      830           
  Misses        110      110           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


See more solvers in [Steady State Solvers · DifferentialEquations.jl](https://diffeq.sciml.ai/stable/solvers/steady_state_solve/)

```julia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the doctesting?

Copy link
Contributor Author

@Song921012 Song921012 Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Chris, Project.toml only includes OrdinaryDiffEq, document.yml is not successful. I an afraid that I mess you doctest up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Chris. Thank you.

@ChrisRackauckas
Copy link
Member

@xtalax there are test failures on master? That's not good.

@xtalax
Copy link
Member

xtalax commented Jun 18, 2022

The CI was passing on last merge, the fail was on nonuniform right? There are some rand calls on those tests, some of those values may push the tests outside of tolerance. I can hard code some suitable values if that is preferable.

@xtalax
Copy link
Member

xtalax commented Jun 18, 2022

@Song921012 please push a dummy commit to verify this

@Song921012
Copy link
Contributor Author

@Song921012 Song921012 closed this Jun 18, 2022
@Song921012 Song921012 reopened this Jun 18, 2022
@Song921012
Copy link
Contributor Author

Sorry, wrong click! I will dummy commit. @xtalax

@ChrisRackauckas ChrisRackauckas merged commit 60018ac into SciML:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants