Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata and Solution interfaces - Multiple order of magnitude faster solution retrieval #154

Merged
merged 36 commits into from
Sep 17, 2022

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Aug 23, 2022

Adds metadata and solution interfaces

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #154 (ce311a6) into master (0c6474c) will decrease coverage by 0.56%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   89.41%   88.84%   -0.57%     
==========================================
  Files          25       31       +6     
  Lines        1228     1390     +162     
==========================================
+ Hits         1098     1235     +137     
- Misses        130      155      +25     
Impacted Files Coverage Δ
...ion/schemes/upwind_difference/upwind_difference.jl 88.23% <ø> (+0.35%) ⬆️
src/interface/MOLMetadata.jl 0.00% <0.00%> (ø)
src/interface/solution/common.jl 65.11% <65.11%> (ø)
src/interface/solution/timedep.jl 90.00% <90.00%> (ø)
src/MOL_discretization.jl 82.81% <100.00%> (+0.69%) ⬆️
src/MOL_utils.jl 82.97% <100.00%> (+0.12%) ⬆️
src/interface/solution/MOLMetadata.jl 100.00% <100.00%> (ø)
src/interface/solution/solution_utils.jl 100.00% <100.00%> (ø)
src/interface/solution/timeindep.jl 100.00% <100.00%> (ø)
src/error_analysis.jl 11.11% <0.00%> (-0.89%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax xtalax changed the title Metadata and Solution interfaces Metadata and Solution interfaces - Multiple order of magnitude faster solution retrieval Sep 8, 2022
@xtalax
Copy link
Member Author

xtalax commented Sep 17, 2022

@ChrisRackauckas Everything passing except invalidations, is this ok to merge?

@ChrisRackauckas ChrisRackauckas merged commit 73228f6 into SciML:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants