Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex Number Support 2 #342

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Complex Number Support 2 #342

merged 5 commits into from
Dec 4, 2023

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Nov 30, 2023

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Adds complex number support, does this by splitting the system in to real and imaginary parts.

fixes #58
fixes #101

depends on SciML/PDEBase.jl#22

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a04e094) 83.02% compared to head (e240a06) 84.79%.
Report is 40 commits behind head on master.

Files Patch % Lines
src/interface/solution/common.jl 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   83.02%   84.79%   +1.76%     
==========================================
  Files          40       41       +1     
  Lines        1756     1960     +204     
==========================================
+ Hits         1458     1662     +204     
  Misses        298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xtalax xtalax merged commit 916a7ee into SciML:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex Number support One-dimensional NLS using MethodOfLines ‘type Array has no field lhs`
1 participant