Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always build initialization problem #3347

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

feat: always build initialization problem #3347

wants to merge 36 commits into from
+392 −210

Conversation

AayushSabharwal
Copy link
Member

I'll link issues this closes once the PR is ready and I've added tests for them.

@AayushSabharwal AayushSabharwal mentioned this pull request Jan 21, 2025
Draft
@TorkelE TorkelE mentioned this pull request Jan 21, 2025
Open
@AayushSabharwal AayushSabharwal mentioned this pull request Jan 22, 2025
Open
@ChrisRackauckas ChrisRackauckas mentioned this pull request Jan 22, 2025
Open
@AayushSabharwal
fix: handle case when parameter object is nothing in `GetUpdatedMTK…
a16368a 
…Parameters`
@AayushSabharwal
feat: update u0map and pmap in build_operating_point
7c3cda3
@AayushSabharwal
feat: add dummy initialization parameters instead of hard constraints
e0288b6
@AayushSabharwal
feat: always build initialization problem, handle dummy parameters
da867ec
@AayushSabharwal
refactor: allow disabling gensym in similar_variable
3156e81
@AayushSabharwal
feat: count shift equations as differential equations
fd376e4
@AayushSabharwal
test: provide missing parameters to NonlinearProblem test
41a2400
@AayushSabharwal
feat: add force_time_independent keyword to InitializationProblem
88d85a7
@AayushSabharwal
feat: expose force_time_independent through process_SciMLProblem
17e9fe0
@AayushSabharwal
fix: remove delayed terms in initialization system of DDEs
4dfd9d3
@AayushSabharwal
fix: only add dummy parameters for unknowns of time-dependent systems
c443665
@AayushSabharwal
fix: change differential operator when building initialization for `D…
fb845d0 
…iscreteSystem`
@AayushSabharwal
fix: handle recursive default edge case in initializesystem
0b130e9
@AayushSabharwal
fix: remove occurrences of dummy parameters when remaking initializeprob
496410b
@AayushSabharwal
fix: only set solvable parameter values to zero in limited cases
aa922b2
@AayushSabharwal
fix: build initialization for DiscreteProblem(::DiscreteSystem)
c9a1f01
@AayushSabharwal
fix: ensure initialization systems for SteadyStateProblem do not in…
4244e30 
…volve independent variable
@AayushSabharwal
test: disambiguate observed in initializesystem tests
55cfe18
@AayushSabharwal
test: remove unnecessary test
5b73c33
@AayushSabharwal
test: refactor initialization_data === nothing tests
e72fd2b
@AayushSabharwal
test: update initializeprob type promotion test
cdde9aa
@AayushSabharwal
fix: don't build initialization for JumpProblem
52c3a53
@AayushSabharwal
fix: don't use observed equations for initialization of DiscreteSystem
83a8e1c
@AayushSabharwal
build: bump SciMLBase version
25339a6
@AayushSabharwal
fix: populate observed into u0map for time-independent systems
7ebeb78
@AayushSabharwal
fix: remove incorrect fix to dummy derivatives in u0map added in Sc…
2844170 
…iML#3337
@AayushSabharwal
fix: fix _eq_unordered for multiple identical values in both a an…
cf67f77 
…d `b`
@AayushSabharwal
fix: do not build initialization for DiscreteProblem
456c056
@AayushSabharwal
test: make NonlinearSystem initialization tests less temperamental
779864c
@AayushSabharwal
test: mark initialization of JumpSystem as broken
e1e53f5
@AayushSabharwal
fix: fix ReconstructInitializeprob overriding guesses
80d1fa0
@AayushSabharwal
feat: propagate algebraic_only kwarg in InitializationProblem
fc9b773
@AayushSabharwal
fix: filter nothing values in op/u0map/pmap in `process_SciML…
8a16286 
…Problem`
@AayushSabharwal
feat: propagate algebraic_only, allow_incomplete kwargs to initia…
f9704e6 
…lization in `process_SciMLProblem`
@AayushSabharwal
fix: use SciMLBase.get_initial_values in linearization_function
10784ba
@AayushSabharwal
fix: do not forward keywords to linearize in AnalysisPoint linear…
93efab1 
…ization functions
@AayushSabharwal AayushSabharwal marked this pull request as ready for review January 24, 2025 07:42
@AayushSabharwal
Copy link
Member Author

The updated initialization was causing problems for linearization. #3348 already fixed initialization in linearization_function so hacking something here only for it to be overwritten is pointless. #3348 is now merged into this PR.

@AayushSabharwal AayushSabharwal mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AayushSabharwal