Re-test enzyme

[Vaibhavdixit02]

Checklist

• Appropriate tests were added
• Any code changes were done in a way that does not break public API
• All documentation related to code changes were updated
• The new code follows the
  contributor guidelines, in particular the SciML Style Guide and
  COLPRAC.
• Any new documentation only uses public API

Additional context

Add any other context about the problem here.

[Vaibhavdixit02]

https://github.com/SciML/OptimizationBase.jl/actions/runs/9276344283/job/25523222868?pr=53#step:6:1044

[wsmoses]

@Vaibhavdixit02 can you open an issue with a MWE of the error. I'll try to get it quickly thereafter.

[wsmoses]

@Vaibhavdixit02 @ChrisRackauckas do you have a MWE (I didn't see one by chance). I'll try to get it fixed quickly

[Vaibhavdixit02]

I literally mentioned this to Chris like 2 hours ago haha, we are on the same page. Would you be able to help review the sparse support here? I started the effort in the previous home for this code https://github.com/SciML/Optimization.jl/pull/688/files I'll revive that

[Vaibhavdixit02]

Ref MWE let's see if the latest release still throws the same error first

[ChrisRackauckas]

This is now blocking SciML/SciMLSensitivity.jl#1067

[wsmoses]

again, happy to help but need a MWE.

In interim just going to be plugging away at mixed activity stuff.

[wsmoses]

bumping this

[Vaibhavdixit02]

I have been trying to recreate but ended up with a duplicated returns not handled error instead of the one on CI here - when running ]test this one does show up so it's kind of tricky to figure out a MWE. The issue happens in hessian of a out-of-place closure created here

OptimizationBase.jl/ext/OptimizationEnzymeExt.jl

Lines 368 to 377 in 581f4f8

	fncs = map(1:num_cons) do i
	function (x)
	return f.cons(x, p)[i]
	end
	end
	function f2(x, dx, fnc)
	Enzyme.autodiff_deferred(Enzyme.Reverse, fnc, Enzyme.Duplicated(x, dx))
	return nothing
	end

I suspect the f2 is incorrect but have been unable to pin down the exact issue yet (I am still trying)

[wsmoses]

That implies type inference fails. Assuming the return is a float, that should likely be changed to the following to explicitly specify that the return is active (if type inference fails)

 function f2(x, dx, fnc) 
     Enzyme.autodiff_deferred(Enzyme.Reverse, fnc, Enzyme.Active, Enzyme.Duplicated(x, dx)) 
     return nothing 
 end