Add 5-arg mul!
#40
Merged
Add 5-arg mul!
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR simply adds a 5-arg `mul!` for `AbstractDiffEqLinearOperator`. I'd like this functionality to be able to compose more things together and facilitate in place computations of sums of ODE-like functions and linear operators, i.e. something like `f(u) + L * u`: ```julia f(du, u, p, t) # some in-place function writes du <- f(u) mul!(du, L, u, 1, 1) # du <- L * u + f(u) ``` I'm not sure this is the right way to add this, please let me know if I need to think more about it! 😅 My current thinking is that I could use that, but maybe there's just no need for it? 🤷
|
Yeah I think there might be some downstream piracy to delete? |
|
Can you rebase? |
|
Done! (I think 😅) |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
- Coverage 9.66% 9.66% -0.01%
=========================================
Files 39 39
Lines 2825 2826 +1
=========================================
Hits 273 273
- Misses 2552 2553 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a 5-arg
mul!forAbstractDiffEqLinearOperator.I'd like this functionality to be able to compose more things together and facilitate in place computations of sums of ODE-like functions and linear operators, i.e. something like
f(u) + L * u:I'm not sure this is the right way to add this, please let me know if I need to think more about it! 😅 My current thinking is that I could use that, but maybe there's just no need for it? 🤷