-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Enzyme 0.11.0 #847
Test Enzyme 0.11.0 #847
Conversation
@wsmoses it looks like we get 0 gradient issues with the latest Enzyme. |
Got a test/reproducer? Also are you using the 0.11.5 that was released a few hours ago, or a different one? |
It was 0.11.4. Was that known to have some issues? https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/5535634554/jobs/10102198548?pr=1984#step:6:628 Pretty much every test failed with it. Running 0.11.5 now. |
No correctness ones that I'm aware of, so having a test would be useful for sure. |
Yup when I allow v0.11.5 the error pop right back up. Suddenly gradients are either incorrect or zero. I'm at a hackathon this week and next so I cannot look into it deeper, so I'm going to hardcode back to v0.11.0 for now. |
I have confirmed at least one of your issues is bug in the KernelAbstractions extension package (see JuliaGPU/KernelAbstractions.jl#412), hence any Enzyme version bumps will not fix the issue, since the issue is in another package. In any case it requires the fix to KA to land and be bumped, at least for your test to pass. |
It looks like that was it. I still bumped the patch to keep life simple. Let's see what people throw back at me now 😅 . I think we're getting really close though, the errors are getting more obscure, really nice work @wsmoses! |
No description provided.