Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split project tomls #178

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Split project tomls #178

merged 3 commits into from
Jun 23, 2020

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

well, let's stress test the system? @christopher-dG is there a nice way to rebuild by folder?

@christopher-dG
Copy link
Contributor

Currently no, on two levels:

  • We don't have a way to trigger a rebuild for all files in a folder. It would be pretty easy to implement naively, but it would be most reliable and practical if it spawned N jobs that each pushed to the same branch, instead of 1 job or N branches.
  • The assumption is currently that we're only ever building off of master. Do you think it would be useful to be able to run "check" jobs that build from a separate branch but don't PR?

@christopher-dG
Copy link
Contributor

christopher-dG commented Jun 17, 2020

Okay so I've been thinking about how we can fit all these use cases and maybe this is a decent API:

  • !rebuild <folder>: Rebuild all tutorials in this folder by creating a new branch, then creating N commits that each update one tutorial.
  • !rebuild <folder>/<file>: Rebuild one tutorial.
  • !rebuild: Rebuild one random tutorial.

To choose the branch to build from:

  • If the comment is made in a PR, build from that PR branch
  • If the comment is made in an issue, build from master

To choose the branch to push to:

  • If the comment is made in a PR that was automatically opened, push to that same branch
  • If the comment is made in an issue, push to a random branch

So to test this PR, you would do:

!rebuild introduction

How does this sound? Does it cover all the bases?

@ChrisRackauckas
Copy link
Member Author

If the comment is made in a PR that was automatically opened, push to that same branch

Why not in any PR?

@christopher-dG
Copy link
Contributor

I guess that's not a bad idea either. So if we were to do it in this one, this PR would be updated to also include changes from the rebuilt tutorials?

@ChrisRackauckas
Copy link
Member Author

yeah, it would be nice since usually I don't want to take the time to rebuild locally.

@christopher-dG christopher-dG merged commit 9f10e63 into master Jun 23, 2020
@christopher-dG christopher-dG deleted the Projecttomls branch June 23, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants