Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize mod for real arguments #107

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Specialize mod for real arguments #107

merged 2 commits into from
Mar 16, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Mar 14, 2023

These methods were missing. After this,

julia> mod(static(2), 2)
0

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #107 (9c0aa78) into master (e6e38fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   98.99%   99.00%           
=======================================
  Files           3        3           
  Lines         699      701    +2     
=======================================
+ Hits          692      694    +2     
  Misses          7        7           
Impacted Files Coverage Δ
src/Static.jl 98.81% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub
Copy link
Contributor Author

jishnub commented Mar 16, 2023

I'm unsure why the LoopVectorization test failed, but I doubt that it's because of this PR

@Tokazama
Copy link
Collaborator

Could you bump the version for this?

@chriselrod , I just want to double check with you that that's a nothing to worry about before we release anything. It looks like the tests may have just timed out but I don't want to brake everything.

@chriselrod
Copy link
Collaborator

Yeah, probably unrelated.

@Tokazama Tokazama merged commit f2d944f into SciML:master Mar 16, 2023
@jishnub jishnub deleted the mod branch March 16, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants