Add another missing NamedTuple getindex method for StaticSymbol

[ianfiske]

Fixes #124 . This addresses the need to do

nt = (a=1, b=2, c=3)
nt[(static(:a), static(:b))]

This is a follow-up to #120 and #121.

As noted in #121, the Aqua tests currently fail, but the tests pass otherwise.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (beb08ae) 0.00% compared to head (5219df6) 98.30%.
Report is 4 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #123       +/-   ##
===========================================
+ Coverage    0.00%   98.30%   +98.30%     
===========================================
  Files           3        3               
  Lines         700      706        +6     
===========================================
+ Hits            0      694      +694     
+ Misses        700       12      -688     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisRackauckas]

This test failure is real though. Fix the ambiguity? But I don't know if you can do that without piracy.

[ianfiske]

This test failure is real though. Fix the ambiguity? But I don't know if you can do that without piracy.

Yeah, the Aqua suggestion to implement

 getindex(::NamedTuple, ::Tuple{})

is clearly type piracy, so I'm thinking we should avoid it. But what is the fix? Should I submit at PR to julia base to implement getindex(::NamedTuple, ::Tuple{}) there? Not ideal due to the wait for it to be merged there and released, etc, but if you think this is the path forward, I'll submit a PR.

[Tokazama]

Have you tried specifying at least one element for the tuple (Tuple{<:StaticSymbol, Vararg{<:StaticSymbol}})?

[ianfiske]

Tuple{<:StaticSymbol, Vararg{<:StaticSymbol}}

With

function Base.getindex(x::NamedTuple, symbols::Tuple{<:StaticSymbol, Vararg{<:StaticSymbol}})
    return x[map(known, symbols)]
end

I get

┌ Static
│  WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│  You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.

But this warning goes away with

function Base.getindex(x::NamedTuple, symbols::Tuple{StaticSymbol, Vararg{StaticSymbol}})
    return x[map(known, symbols)]
end

[ChrisRackauckas]

@ArnoStrouwen what does this mean? https://github.com/SciML/Static.jl/actions/runs/7841889229/job/21399128321?pr=123#step:6:1049

[ArnoStrouwen]

My guess would be it fails because dev version of Static gets added to the SciMLBase project here:
https://github.com/SciML/Static.jl/actions/runs/7841889229/job/21399128321?pr=123#step:6:1049
However, Static is normally not a part of SciMLBase, hence Aqua complains it is a stale dep and has no compat entry.

[ChrisRackauckas]

Is there a way to make this one bypass?

[ArnoStrouwen]

I can't think of anything besides moving it out of the core group into its own group, which is then not ran here.

[ChrisRackauckas]

Yeah let's just make a QA group.