Add oneto(::StaticInt{N})
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(T, #= /home/chriselrod/.julia/dev/LoopVectorization/test/broadcast.jl:10 =# @__LINE__()) = (Float32, 10)
broadcast_float: Error During Test at /home/chriselrod/.julia/dev/LoopVectorization/test/broadcast.jl:16
Test threw exception
Expression: LoopVectorization.static_size(bl) === (size(b, 1), size(b, 2), LoopVectorization.StaticInt(1))
MethodError: no method matching Base.OneTo(::Static.StaticInt{1})
Closest candidates are:
Base.OneTo(::T) where T<:Integer
@ Base range.jl:462
Base.OneTo(::AbstractRange{T}) where T<:Integer
@ Base range.jl:463
Stacktrace:
[1] oneto(r::Static.StaticInt{1})
@ Base ./range.jl:464
[2] map
@ ./tuple.jl:291 [inlined]
[3] axes
@ ./abstractarray.jl:98 [inlined]
[4] static_axes
@ ~/.julia/packages/StaticArrayInterface/gJiae/src/axes.jl:111 [inlined]
[5] _maybe_size(#unused#::Base.HasShape{3}, a::LowDimArray{(true, true, false), Float32, 3, Array{Float32, 3}})
@ StaticArrayInterface ~/.julia/packages/StaticArrayInterface/gJiae/src/size.jl:28
[6] static_size
@ ~/.julia/packages/StaticArrayInterface/gJiae/src/size.jl:23 [inlined]Failure from LV's tests on a local branch, updating to ArrayInterface 7. |
ChrisRackauckas
approved these changes
Feb 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 99.42% 99.28% -0.15%
==========================================
Files 3 3
Lines 696 699 +3
==========================================
+ Hits 692 694 +2
- Misses 4 5 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Those piracy checks were false positives. |
Example showing that `IntType` seems to be fine:
```julia
julia> struct Bar end
julia> const MyUnion = Union{Bar,Int}
MyUnion (alias for Union{Bar, Int64})
julia> MyUnion(::Int) = throw("uh oh")
MyUnion (alias for Union{Bar, Int64})
julia> MyUnion(3)
ERROR: "uh oh"
Stacktrace:
[1] MyUnion(#unused#::Int64)
@ Main ./REPL[4]:1
[2] top-level scope
@ REPL[5]:1
julia> Int(3)
3
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.