Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "utf8" instead of "utf-8" to indicate the encoding seems to create issues on Windows, making it unable to install the package.
Now, the python documentation of open uses says that you can use any encoding from here, which states that
'utf-8' is a valid alias for the 'utf_8' codec
.To be fair, "utf8" should work too, but I assume this is not properly supported on Windows.
In any case, all the official examples I could find from the python documentation use "utf-8" (example), so that is probably the safest option.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional information
Tested on