Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct open encoding #158

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: correct open encoding #158

merged 1 commit into from
Jan 23, 2025

Conversation

TendTo
Copy link
Contributor

@TendTo TendTo commented Jan 23, 2025

Using "utf8" instead of "utf-8" to indicate the encoding seems to create issues on Windows, making it unable to install the package.

Now, the python documentation of open uses says that you can use any encoding from here, which states that 'utf-8' is a valid alias for the 'utf_8' codec.
To be fair, "utf8" should work too, but I assume this is not properly supported on Windows.

In any case, all the official examples I could find from the python documentation use "utf-8" (example), so that is probably the safest option.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional information

Tested on

  • Windows 10
  • Python 3.10 (conda environment)

Using the wrong encoding creates issues on Windows
@ChrisRackauckas ChrisRackauckas merged commit 4889eb2 into SciML:master Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants