Adds an exception for missing templates. #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindevans
reviewed
Jan 2, 2025
LLama/Exceptions/RuntimeError.cs
Outdated
| /// <summary> | ||
| /// `llama_decode` return a non-zero status code | ||
| /// </summary> | ||
| public class MissingTemplateError |
There was a problem hiding this comment.
Suggested change
| public class MissingTemplateError | |
| public class MissingTemplateException |
Exception classes should end with Exception (docs).
RuntimeError and LLamaDecodeError break this rule and should be fixed sometime!
martindevans
reviewed
Jan 2, 2025
martindevans
reviewed
Jan 2, 2025
martindevans
requested changes
Jan 2, 2025
phil-scott-78
force-pushed
the
better-error-on-missing-prompt
branch
from
9136f7f to
45a8a19
Compare
|
i even felt a bit dirty typing it out, should have trusted my gut. Got it fixed up and pushed now. |
martindevans
approved these changes
Jan 3, 2025
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better exception handling for when there are missing templates with a model when calling
llama_chat_apply_templateFunny enough, it looks like ggerganov/llama.cpp#10572 added support for my missing template, but still nice to have a better exception down the road.
Closes #1032