LLamaToken Struct #404
Merged
LLamaToken Struct #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to get this one reviewed soon if possible, it touches a lot of files and so it will rapidly become a pain to merge if other PRs are merged. |
|
Sorry didn't see this request, changes look fine to me :) however I don't know the lower levels that well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major change to the API. All uses of
int(orllama_token, aliasingint) to represent a token have been replaced with aLLamaTokenstruct. This makes the API more strongly typed - it's less likely to mix up a token with some other non-token integer.In general fixing any breakage is easy, you can just cast
(int)the_tokenor(LLamaToken)1. Not many places in the basic API deal in raw tokens, and usually work on strings instead, so I'm actually not expecting this to seriously affect many users.