Add CLBLAST native library to native libraries build #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
using bash expansion expression, combined with mkdir -p (--parents), allows us to create all of the directories at once.
`deps/{avx,avx2,avx512,osx-arm64,osx-x64,cu11.7.1,cu12.1.0,clblast}`
expands to: deps/avx deps/avx2 deps/avx512 deps/osx-arm64 deps/osx-x64 deps/cu11.7.1 deps/cu12.1.0 deps/clblast
|
Is this good to merge now? I can see you've got the Linux stuff in there but commented out, do you want to include that in this PR, or merge as is and leave it for the future? |
|
@martindevans it should be good to go. Sorry for the close and reopen, fat fingers on my phone. |
|
Llamacpp doesn't build clblast on Linux, I'll figure that out eventually, but for now windows only. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build llama against CLBLAST (windows only for now)
Passing build: https://github.com/jasoncouture/LLamaSharp/actions/runs/7714965548/job/21028424704
Step 1 of #464
Step 2 will be to update the binaries, and add a new NuGet package spec.