Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semantic Kernel & Kernel Memory Package #612

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

xbotter
Copy link
Collaborator

@xbotter xbotter commented Mar 18, 2024

Summary:
This pull request updates the LLama.SemanticKernel and LLama.Unittest projects. The changes include modifying the LLamaSharpChatCompletion class in the LLama.SemanticKernel project to use the ILLamaExecutor interface instead of the StatelessExecutor class. Additionally, the LLama.Unittest project is updated to include references to the Moq and System.Linq.Async packages. Two new test classes, ExtensionMethodsTests and LLamaSharpChatCompletionTests, are added to the LLama.Unittest project to test the extension methods and LLamaSharpChatCompletion class, respectively.

Changes:

  • Modified the LLamaSharpChatCompletion class in the LLama.SemanticKernel project to use the ILLamaExecutor interface instead of the StatelessExecutor class.
  • Added references to the Moq and System.Linq.Async packages in the LLama.Unittest project.
  • Added a new test class, ExtensionMethodsTests, to test the extension methods.
  • Added a new test class, LLamaSharpChatCompletionTests, to test the LLamaSharpChatCompletion class.
  • Added LLamaSharpTextCompletionTests class to the LLama.Unittest project.
  • Updated package references in the LLama.Examples project to use Microsoft.KernelMemory.Core version 0.34.240313.1, Microsoft.SemanticKernel version 1.6.2, and Microsoft.SemanticKernel.Plugins.Memory version 1.6.2-alpha.
  • Updated package references in the LLama.KernelMemory project to use Microsoft.KernelMemory.Abstractions version 0.34.240313.1.
  • Updated package references in the LLama.SemanticKernel project to use Microsoft.SemanticKernel.Abstractions version 1.6.2.

xbotter added 2 commits March 14, 2024 22:17
- Update Microsoft.KernelMemory.Core to version 0.34.240313.1
- Update Microsoft.SemanticKernel to version 1.6.2
- Update Microsoft.SemanticKernel.Plugins.Memory to version 1.6.2-alpha
- Update Microsoft.KernelMemory.Abstractions to version 0.34.240313.1
- Update Microsoft.SemanticKernel.Abstractions to version 1.6.2
- Updated LLamaSharpChatCompletion class in LLama.SemanticKernel/ChatCompletion/LLamaSharpChatCompletion.cs
  - Changed the type of the "_model" field from "StatelessExecutor" to "ILLamaExecutor"
  - Updated the constructor to accept an "ILLamaExecutor" parameter instead of a "StatelessExecutor" parameter
- Updated LLamaSharpChatCompletion class in LLama.SemanticKernel/LLamaSharp.SemanticKernel.csproj

- Updated LLama.Unittest project in LLama.Unittest/LLama.Unittest.csproj
  - Added a "PackageReference" for "Moq" version 4.20.70
- Added ExtensionMethodsTests class in LLama.Unittest/SemanticKernel/ExtensionMethodsTests.cs
  - Added tests for the "ToLLamaSharpChatHistory" and "ToLLamaSharpInferenceParams" extension methods
- Added LLamaSharpChatCompletionTests class in LLama.Unittest/SemanticKernel/LLamaSharpChatCompletionTests.cs
  - Added tests for the LLamaSharpChatCompletion class

ℹ️ The LLamaSharpChatCompletion class in the LLama.SemanticKernel project has been updated to use the ILLamaExecutor interface instead of the StatelessExecutor class. This change allows for better abstraction and flexibility in the implementation of the LLamaSharpChatCompletion class. The LLamaSharpChatCompletion class is responsible for providing chat completion functionality in the LLamaSharp project. The LLama.Unittest project has also been updated to include tests for the LLamaSharpChatCompletion class and the extension methods used by the class.
@martindevans
Copy link
Member

Does this supersede #590, #591 or #592?

@xbotter
Copy link
Collaborator Author

xbotter commented Mar 19, 2024

Does this supersede #590, #591 or #592?

yep

@martindevans
Copy link
Member

I'll close those ones then.

@AsakusaRinne
Copy link
Collaborator

Many thanks for this contribution!

@AsakusaRinne AsakusaRinne merged commit e3ecc31 into SciSharp:master Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants