KernelMemory update with adding the use of already loaded model #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using KernelMemory one may have already loaded a model which can then be used with this extension instead of loading the model again.
|
Please check that there is no conflict or Dispose problems with this solution before merging. Thank you. |
AsakusaRinne
approved these changes
Mar 28, 2024
|
Can the other overload (which loads the weights) be made to call this new overload? That way we're not duplicating some of the other stuff. |
|
Lifetime management seems ok to me 👍 Both the executor and the embedder will create new contexts, which will keep the model in memory until done. |
Removed code repetition. |
martindevans
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using KernelMemory one may have already loaded a model which can then be used with this extension instead of loading the model again.