-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path to find llama.dll for MAUI #631
Conversation
This commit is originally made by lcarrere in SciSharp#180 . I have confirmed this modification is OK in my windows 11 laptop, add make this commit according require of AsakusaRinne.
This needs to be skipped on non-Windows platforms, or else it'll fail because the imported method does not exist. e.g. check |
RuntimeInformation.IsOSPlatform(OSPlatform.Windows) is already exist, the imported method AddDllDirectory will only run in windows platform:
@martindevans, did I missed something? |
Ah sorry, I didn't zoom out far enough in the diff to see that! In that case it all looks fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you a lot for this contribution!
This commit is originally made by lcarrere in #180 .
I have confirmed this modification is OK in my windows 11 laptop, MAUI could load GGUF model and infer successfully.
I make this commit according require of AsakusaRinne.