Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cuda llava native libraries. #647

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

AsakusaRinne
Copy link
Collaborator

@AsakusaRinne AsakusaRinne commented Apr 3, 2024

The files are from Action 8518332362, with no updating for llama.cpp commit.

@martindevans
Copy link
Member

One of the files is called LLama\runtimes\deps\cu11.7.1\libllama_shared.so, should that be LLama\runtimes\deps\cu11.7.1\libllava_shared.so (llava instead of llama)?

@AsakusaRinne
Copy link
Collaborator Author

One of the files is called LLama\runtimes\deps\cu11.7.1\libllama_shared.so, should that be LLama\runtimes\deps\cu11.7.1\libllava_shared.so (llava instead of llama)?

Yes, I misspelled that in the workflow. I have fixed this typo and manually renamed the file before submitting this PR.

@AsakusaRinne
Copy link
Collaborator Author

@martindevans I think we should publish a patch release since it's a severe performance issue, as shown in #639 and #650. Do you have other works that want to be included together in 0.11.2?

@martindevans
Copy link
Member

Shall we merge #649 and then do a patch release with this PR?

We'll probably need to do another patch release in a few days to fix the publish issue we were discussing on Discord. That's not really a problem though.

@AsakusaRinne
Copy link
Collaborator Author

Shall we merge #649 and then do a patch release with this PR?

I think it's a good idea.

We'll probably need to do another patch release in a few days to fix the publish issue we were discussing on Discord. That's not really a problem though.

That's why it's called patch release! :)

@martindevans
Copy link
Member

@AsakusaRinne #649 has been reviewed and merged, you can go ahead and merge this one when you're ready :)

@AsakusaRinne AsakusaRinne merged commit 0458508 into SciSharp:master Apr 6, 2024
3 checks passed
@AsakusaRinne AsakusaRinne mentioned this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants