-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemanticKernel: Correcting non-standard way of working with PromptExecutionSettings #689
Conversation
Sorry for the list of commits. Until one is not merged it keeps listing all former ones... only the last commit is active here: |
If you work in a separate branch in your fork and then PR just that branch you won't get a messy commit log like that. For this one, we'll just make sure to squash-and-merge so it all becomes on commit :) |
…PromptExecutionSettings can be used downstream to post-process the messages based on the requested format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me except one concern. Thank you a lot for this PR!
…omptExecutionSettings
The extension of PromptExecutionSettings is not only for ChatCompletion, but also for text completion and text embedding.