Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Unnecessary Constructor From Safe Handles #696

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Removed Unnecessary Constructor From Safe Handles #696

merged 2 commits into from
Apr 26, 2024

Conversation

martindevans
Copy link
Member

  • Removed unnecessary constructors from safe handles
  • Returning SafeLLamaGrammarHandle directly from llama_grammar_init and llama_grammar_copy instead of raw IntPtr

@martindevans
- Removed unnecessary constructors from safe handles
54dab27 
 - Returning SafeLLamaGrammarHandle directly from `llama_grammar_init` and `llama_grammar_copy`
AsakusaRinne
AsakusaRinne approved these changes Apr 26, 2024
View reviewed changes
LLama/Native/SafeLLamaGrammarHandle.cs Outdated Show resolved Hide resolved
@martindevans martindevans merged commit 18586cc into SciSharp:master Apr 26, 2024
3 checks passed
@martindevans martindevans deleted the safe_handle_constructor_refactor branch April 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsakusaRinne AsakusaRinne AsakusaRinne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martindevans @AsakusaRinne