Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to check the spellings. #710

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

AsakusaRinne
Copy link
Collaborator

@AsakusaRinne AsakusaRinne commented Apr 29, 2024

Typo (incorrect spelling) is a problem that's hard to be completely eliminated during the review. When we realize a spelling problem, it might have already come across several versions. This PR introduces a workflow to detect the possible typos to help us find them.

If a word or a file is incorrectly checked, you can modify .github/_typo.toml to skip check for it. Here's the reference.

@@ -209,7 +209,7 @@ protected virtual void HandleRunOutOfContext(int tokensToKeep)
/// <summary>
/// Try to reuse the matching prefix from the session file.
/// </summary>
protected virtual void TryReuseMathingPrefix()
Copy link
Member

@martindevans martindevans Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change. But I'm not too concerned about it in this case tbh.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mention it in the next release note. :)

@martindevans
Copy link
Member

Looks good! The number of typos this has caught already demonstrates it's worth!

@AsakusaRinne AsakusaRinne merged commit f44c884 into SciSharp:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants