-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions #74
GitHub actions #74
Conversation
I've added a single test which simply loads and disposes a model (previously there were no tests). I'm not sure why this is failing on Linux and MacOS, probably an issue with the way the test project was set up but I'm not sure what. |
Someone on Discord (jlsantiago) did some investigation into why this is failing on Mac. No conclusion yet. Here's the conversation for reference: https://discord.com/channels/1106946823282761851/1106947264938790972/1137050602711560252 |
It looks like there was some issues Marshaling the tensor_split affecting Linux and Mac I have commited a fix 2b5efa0 that should work on all platforms, can confirm Winows and Linux, but I dont have a recent compilation of the Mac lib to test However 99% sure this will also work for mac also EDIT: Actions now successful for Linux |
@saddam213 thanks for investigating this 👍 Would you mind opening a PR into my fork for this fix? |
I think this branch predates the tensor_split change in llama.cpp |
- using 6.0.x instead of 7.0.x
…m huggingface. This can be used for unit tests. - Caching that folder, so CI only has to download it once.
8b42d06
to
d6fc83e
Compare
@saddam213 I've rebased this branch onto master, so it should be fully up to date now. Note: this has broken the CI on Windows, since the DLLs are out of date right now |
Added some simple CI which builds the project and runs tests in debug and release mode on Linux, Windows and MacOS.
I've added an action to download a model into the test project as part of the build. This file is not comitted to the repo, but it's cached in the CI so it should be fast after the first time.
This also incorporates a fix to the netstandard2.0 build (formerly #73) so that the CI doesn't immediately fail!