NAME loader fixes #4411
Merged
NAME loader fixes #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
approved these changes
Nov 12, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 7, 2021
* main: (23 commits) Suggest type hinting (SciTools#4390) area weight regrid test fixes (SciTools#4432) Update latest.rst (SciTools#4425) Added @wjbenfold to the core dev list (SciTools#4423) Removed addition of period from wrap_lons. (SciTools#4421) Add release docs sections describing the role of a Release Manager (SciTools#4413) Subset should always return None if no value matches are found (SciTools#4417) What's new for SciTools#4400 (SciTools#4422) `iris.analysis.AreaWeighted` regrid speedup (SciTools#4400) [pre-commit.ci] pre-commit autoupdate (SciTools#4419) Remove newline to satisfy setuptools (SciTools#4418) Updated environment lockfiles (SciTools#4416) NAME loader fixes (SciTools#4411) Updated whatsnew for PR 4402 (SciTools#4410) Support test data in benchmark workflows (SciTools#4402) What's new for pr 4387 (SciTools#4405) Make concat mismatch warning for scalar coords more accurate (SciTools#4387) Added line to latest release notes for updates to pp_save_rules.py (SciTools#4404) Update pp_save_rules.py (SciTools#4391) [pre-commit.ci] pre-commit autoupdate (SciTools#4403) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
I recently discovered that as part of unpinning cftime in version 3.0.4 (#4222), a bug was introduced that makes it impossible to load a NAME file that contains only one time point. (Because
np.float_(arr)on an array with one element returns a scalar, instead of another array with one element.)I took the opportunity to fix some long-standing annoyances that we've so far just worked around:
positive = up, so the "axis" was not guessed as "Z".Consult Iris pull request check list