Simplify and lazify broadcast_to_shape (#5307) #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* working for all except masked lazy * use moveaxis * handle lazy masked case * add tests for is_lazy_masked_data * whatsnew * check compute isn't called * update docstring
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3.6.x #5359 +/- ##
==========================================
+ Coverage 89.32% 89.34% +0.01%
==========================================
Files 89 89
Lines 22398 22400 +2
Branches 5375 5373 -2
==========================================
+ Hits 20008 20014 +6
+ Misses 1640 1638 -2
+ Partials 750 748 -2
☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks @bjlittle. The What's New entry looks good, and is consistent with previous times when this was necessary.
|
Note I have knowingly forced some conflict resolution when we next do the merge-back from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This pull-request
cherry-picks the merge commit (48e3a86) of #5307 frommainto thev3.6.xrelease feature branch.This is required to support #5341 in the v3.6.1 patch release.
Consult Iris pull request check list