-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv-git: Migrate 64-bit builds to v3 #11123
base: master
Are you sure you want to change the base?
Conversation
/verify |
All changes look good. Wait for review from human collaborators. mpv-git
|
Name Modified Downloads/Week
I Totally like that. |
versions bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest the following to be done before I approve this request:
- An old version must be placed in the Versions bucket.
- A note in this bucket saying that certain CPUs will not run and they should download the one in Versions bucket instead.
@jasongodev mpv-v3 hasn't released a stable version yet, so I invite you to review this pr: ScoopInstaller/Versions#1187 |
Potentially, I could PR more granular arch detection in ScoopInstaller/Scoop, to have separate archs called |
This may break compatibility with older CPUs (to my understanding CPUs from the past 10 years should work), so it's understandable if this is not wanted. Maybe versions, or a separate
mpv-git-v3
in extras is a better place for something like this.README.rst
markdown converted:Difference between x86_64 and x86_64-v3
x86_64-v3 builds have these instructions enabled by default:
CPUs which don't have these features will fail to launch the x86_64-v3 build