Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv-git: Migrate 64-bit builds to v3 #11123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Apr 23, 2023

This may break compatibility with older CPUs (to my understanding CPUs from the past 10 years should work), so it's understandable if this is not wanted. Maybe versions, or a separate mpv-git-v3 in extras is a better place for something like this.

README.rst markdown converted:

Difference between x86_64 and x86_64-v3

x86_64-v3 builds have these instructions enabled by default:

  avx avx2 bmi bmi2 fma lzcnt movbe sse3 sse4 sse4.1 sse4.2 ssse3 xsave sahf mwait crc32 cx16 popcnt f16c

CPUs which don't have these features will fail to launch the x86_64-v3 build

@brian6932
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mpv-git

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@b4imetu
Copy link
Contributor

b4imetu commented Apr 24, 2023

Name Modified Downloads/Week
64bit-v3 2023-04-23 5,299
32bit 2023-04-23 313
64bit 2023-04-23 7,441

Maybe versions, or a separate mpv-git-v3 in extras is a better place for something like this.

I Totally like that.

@HUMORCE
Copy link
Member

HUMORCE commented Apr 25, 2023

versions bucket.

Copy link
Contributor

@jasongodev jasongodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the following to be done before I approve this request:

  • An old version must be placed in the Versions bucket.
  • A note in this bucket saying that certain CPUs will not run and they should download the one in Versions bucket instead.

@b4imetu
Copy link
Contributor

b4imetu commented May 11, 2023

@jasongodev mpv-v3 hasn't released a stable version yet, so I invite you to review this pr: ScoopInstaller/Versions#1187

brian6932 added a commit to brian6932/Versions that referenced this pull request Oct 1, 2023
@brian6932
Copy link
Contributor Author

brian6932 commented Oct 3, 2023

Potentially, I could PR more granular arch detection in ScoopInstaller/Scoop, to have separate archs called 64bit-v2 (SSE4.2), 64bit-v3 (AVX2), 64bit-v4 (AVX512)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants